- Jan 2022
-
-
let info, id
let id = response.headers.get("X-Request-ID"); if (id) { let info = this._pendingRequests.get(id); if (info) {
-
filter = null
This is unused.
-
- Nov 2021
-
-
connection
Unused. Caller can/should be passing this in so we can handle the quota check internally.
-
- Sep 2021
-
-
this.ontokencontent = this.ontokencontent.call(this, result)
The implicitness that this "protocol" pushes into the implementing methods (seemingly odd return values) is undesirable. Make it explicit. The implementing methods should be able to do something like
Validator.changeExpectation(this, this.onresource)
(which in turn changes the target'sontokencontent
handler).
-
-
www.colbyrussell.com www.colbyrussell.com
-
|| minted == hinted
Unnecessary check.
Tags
Annotators
URL
-
- Jul 2021
-
www.colbyrussell.com www.colbyrussell.com
-
this._figureElement = this._page.querySelector("script");
Better to use
querySelectorAll
and then filter based on figure designation (e.g.nodeValue.startsWith(" (Fig. 1) ")
). -
document
Unused!
(Caller should also probably look more like:
let system = new SystemB(document); system.attach(document.querySelectorAll("script"))
... where the
querySelectorAll
return value's role is to act as a list of document figures, for the reasons described elsewhere https://hypothes.is/a/-n-RYt4WEeu5WIejr9cfKA.)
Tags
Annotators
URL
-