Log in Sign up
1 Matching Annotations
  1. Feb 2021
  2. github.com github.com
    Why another form object? · Issue #3 · GCorbel/activeform-rails
    1
    1. TylerRick 16 Feb 2021
      in Public
      My concern with this approach is still that it's somewhat brittle with the current implementation of valid? because whilst valid? appears to be a predicate and should have no side effects, this is not the case and could remove the errors applied by one of the steps above.
      evolved into unfortunate state and too late to fix now surprising behavior rails: validation should have no side effects rails: validation: valid? has side effects
    Visit annotations in context

    Tags

    • should have no side effects
    • evolved into unfortunate state and too late to fix now
    • rails: validation
    • rails: validation: valid? has side effects
    • surprising behavior

    Annotators

    • TylerRick

    URL

    github.com/GCorbel/activeform-rails/issues/3
Share:
Group. Only group members will be able to view this annotation.
Only me. No one else will be able to view this annotation.
Hypothes.is
  • About
  • Blog
  • Bioscience
  • Education
  • Jobs
  • Help
  • Contact
  • Terms of Service
  • Privacy Policy