I haven't researched where the color-coding thing started, though I suspect content creators/influencers online in the last decades as a means of making their content "pretty" rather than necessarily functional.
Historically commonplaces were based on huge varieties of topics/subject headings, so colors and symbols were not frequently used. Most who needed greater organization or search capabilities indexed their commonplaces. One of the most popular means was detailed by philosopher John Locke in 1685. Here's some pointers to his work in this area in my own digital commonplace using Hypothesis: https://hypothes.is/users/chrisaldrich?q=tag%3A%22commonplace+books%22+tag%3A%22John+Locke%22
reply to u/_cold_one at https://old.reddit.com/r/commonplacebook/comments/1hhavye/20_topics_colour_coding/