You can afford to make a proper PR to upstream.
7 Matching Annotations
- Dec 2020
-
www.npmjs.com www.npmjs.com
-
-
The change would be useful to other people as-is.
-
The change is too consequential to be developed in situ.
-
Patches can be reviewed as part of your normal review process, forks probably can't
-
Get told in big red letters when the dependency changed and you need to check that your fix is still valid.
-
Keep your patches colocated with the code that depends on them.
-
Sometimes forks need extra build steps, e.g. with react-native for Android. Forget that noise.
Tags
- advantages/merits/pros
- doing it right/properly
- forking (patching vs. forking)
- review process
- taking the time to do it right/properly
- helpful
- patching (patching vs. forking)
- limited time: not right now (maybe later)
- too hard/complicated/non-trivial
- errors/warnings are helpful for development
- code organization: co-location
- pull request
- when to _
- proper
- patching vs. forking
Annotators
URL
-