5 Matching Annotations
- Dec 2022
-
www.zhihu.com www.zhihu.com
-
upsource的使用体验如何?
Tags
Annotators
URL
-
-
www.zhihu.com www.zhihu.com
-
大家的公司的 Code Review 都是怎么做的？遇到过哪些问题？
Tags
Annotators
URL
-
- Jul 2022
-
news.ycombinator.com news.ycombinator.com
-
Review: a formal assessment or examination of something with the possibility or intention of instituting change if necessary.
(comment with good examples of code review comments)
Tags
Annotators
URL
-
- Dec 2020
-
www.michaelagreiler.com www.michaelagreiler.com
-
codereviews
-
- Apr 2020
-
google.github.io google.github.io
-
Summary
In doing a code review, you should make sure that:
- The code is well-designed.
- The functionality is good for the users of the code.
- Any UI changes are sensible and look good.
- Any parallel programming is done safely.
- The code isn’t more complex than it needs to be.
- The developer isn’t implementing things they might need in the future but don’t know they need now.
- Code has appropriate unit tests.
- Tests are well-designed.
- The developer used clear names for everything.
- Comments are clear and useful, and mostly explain why instead of what.
- Code is appropriately documented (generally in g3doc).
- The code conforms to our style guides.
-